Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a nicer interactive frontend to show which steps are executing #33

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

BenjaminSchubert
Copy link
Owner

This allows users to have a more dynamic view of what is happening and
overall gives better feedback

This does not entirely fix #7, but we might not actually need something more complex here

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 89.60% // Head: 87.81% // Decreases project coverage by -1.80% ⚠️

Coverage data is based on head (8cb3536) compared to base (e34a16f).
Patch coverage: 51.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   89.60%   87.81%   -1.80%     
==========================================
  Files          48       51       +3     
  Lines        1992     2093     +101     
  Branches      266      275       +9     
==========================================
+ Hits         1785     1838      +53     
- Misses        151      195      +44     
- Partials       56       60       +4     
Impacted Files Coverage Δ
src/dwas/_io.py 78.65% <27.27%> (-2.53%) ⬇️
src/dwas/_frontend.py 47.36% <47.36%> (ø)
tests/test_config.py 95.65% <66.66%> (-4.35%) ⬇️
src/dwas/_pipeline.py 84.43% <84.61%> (-0.39%) ⬇️
src/dwas/_config.py 94.59% <100.00%> (+0.07%) ⬆️
src/dwas/__init__.py 100.00% <0.00%> (ø)
tests/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BenjaminSchubert BenjaminSchubert force-pushed the bschubert/nicer-frontend branch 2 times, most recently from a542f62 to fa62f6f Compare February 11, 2023 19:43
This allows users to have a more dynamic view of what is happening and
overral gives better feedback
@BenjaminSchubert BenjaminSchubert marked this pull request as ready for review February 11, 2023 20:45
@BenjaminSchubert BenjaminSchubert merged commit 82b0c0b into main Feb 11, 2023
@BenjaminSchubert BenjaminSchubert deleted the bschubert/nicer-frontend branch February 11, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a nicer frontend for interfactive workflows
1 participant